Fix override errors. #53
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When set override = {"wannier90":{"meta_parameters":{SOMETHING}}},
the `inputs` will automatically set to:
{"wannier90":{"meta_parameters":{SOMETHING, "exclude_semicore": True}}}.
This will make the check of overlap_semicores invalid.
Use `deepcopy` to temp fix it, maybe further check is needed.
|
All contributors have accepted the CLA ✅ You might need to click the "Update/Rebase branch" button to update the pull request and rerun the GitHub actions to pass the CLA check. |
|
I have read the CLA Document and I hereby accept the CLA |
|
great, thanks! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When set
override = {"wannier90":{"meta_parameters":{SOMETHING}}}, theinputswill automatically set to:{"wannier90":{"meta_parameters":{SOMETHING, "exclude_semicore": True}}}. This will make the check ofoverlap_semicoresinvalid.Use
deepcopyto temp fix it.