Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove code needed for AiiDA v1 #90

Merged
merged 1 commit into from
Dec 7, 2024
Merged

Remove code needed for AiiDA v1 #90

merged 1 commit into from
Dec 7, 2024

Conversation

danielhollas
Copy link
Collaborator

Follow up to #87

@danielhollas danielhollas requested a review from ltalirz December 6, 2024 15:33
@codecov-commenter
Copy link

codecov-commenter commented Dec 6, 2024

Codecov Report

Attention: Patch coverage is 92.85714% with 1 line in your changes missing coverage. Please review.

Project coverage is 92.60%. Comparing base (63a3f44) to head (180bd0f).

Files with missing lines Patch % Lines
aiida_test_cache/archive_cache/_utils.py 92.85% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #90      +/-   ##
==========================================
+ Coverage   89.00%   92.60%   +3.60%     
==========================================
  Files           9        9              
  Lines         482      460      -22     
==========================================
- Hits          429      426       -3     
+ Misses         53       34      -19     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ltalirz
Copy link
Member

ltalirz commented Dec 7, 2024

feel free to go ahead with these PRs

@danielhollas danielhollas merged commit 094bdb7 into main Dec 7, 2024
7 checks passed
@danielhollas danielhollas deleted the remove-v1-code branch December 7, 2024 12:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants