Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove redundant streaming in download of file #77

Merged
merged 1 commit into from
Nov 26, 2024

Conversation

agoscinski
Copy link
Collaborator

In PR #71 a streaming mechanism has been implemented for the endpoint /nodes/{nodes_id}/download, this however is already taken care by FastAPI StreamingResponse and is therefore redundant and can be removed.

@agoscinski agoscinski force-pushed the rm-redundant-streaming branch from bb6d8e1 to ad2772f Compare November 21, 2024 11:52
In PR #71 a streaming mechanism has been implemented for the endpoint
`/nodes/{nodes_id}/download`, this however is already taken care by
FastAPI StreamingResponse and is therefore redundant and can be removed.
@agoscinski agoscinski force-pushed the rm-redundant-streaming branch from ad2772f to 4c41935 Compare November 21, 2024 12:47
@agoscinski agoscinski merged commit 87cf264 into master Nov 26, 2024
8 of 9 checks passed
@agoscinski agoscinski deleted the rm-redundant-streaming branch November 26, 2024 16:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants