Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Creates Group model for post #29

Merged
merged 3 commits into from
Jul 19, 2021
Merged

Creates Group model for post #29

merged 3 commits into from
Jul 19, 2021

Conversation

NinadBhat
Copy link
Collaborator

Fixes #26

@NinadBhat NinadBhat requested a review from chrisjsewell June 18, 2021 10:43
@codecov-commenter
Copy link

Codecov Report

Merging #29 (836b8cc) into master (ac1ccf3) will increase coverage by 0.15%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #29      +/-   ##
==========================================
+ Coverage   92.09%   92.24%   +0.15%     
==========================================
  Files          25       25              
  Lines         746      761      +15     
==========================================
+ Hits          687      702      +15     
  Misses         59       59              
Flag Coverage Δ
pytests 92.24% <100.00%> (+0.15%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
aiida_restapi/models.py 95.89% <100.00%> (+1.06%) ⬆️
aiida_restapi/routers/groups.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ac1ccf3...836b8cc. Read the comment docs.

@ltalirz
Copy link
Member

ltalirz commented Jul 9, 2021

@chrisjsewell Just a reminder to please add your review of this PR

@ltalirz ltalirz merged commit 35ea00f into aiidateam:master Jul 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Incorrect input field specification for POST methods
4 participants