Bug: PhBaseWorkChain.set_qpoints doesn't work as expected
#1005
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `set_qpoints` method was untested and contained many typos and bugs, which would break the usage of the workchain when a `qpoints_distance` is used and would set wrong `qpoints` in the context inputs.
mbercx
reviewed
Feb 11, 2024
There was a problem hiding this comment.
Thanks @bastonero! Changes look good, just left a small comment.
mbercx
approved these changes
Feb 12, 2024
There was a problem hiding this comment.
Thanks @bastonero, let's merge this and do patch release. 🚀
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1004
The
set_qpointsmethod was untested and contained many typos and bugs, which would break the usage of the workchain when aqpoints_distanceis used and would set wrongqpointsin the context inputs.