Skip to content

Commit

Permalink
get_xspectra_structures: Refactor and Improve Code
Browse files Browse the repository at this point in the history
Refactors major components of `get_xspectra_structures` as part of
ongoing improvement work. These changes are the first of two
improvements intended to enable users to set symmetry data manually
instead of relying on automatic symmetry analysis - ultimately enabling
the same feature for the `XspectraCrystalWorkChain` and any others which
use the same structure preparation tools.

Changes:
* Moves supercell creation, processes for molecules, and generation of
  `equivalent_sites_data` to separate functions.
* Adds functionality for users to manually provide symmetry data, thus
  enabling the `CalcFunction` to be used as a means to generate structures
 with user control over which exact sites to mark.
* Fixes a bug discovered in the case where non-hubbard structures with
  custom Kind names lost their Kind names when converting the ASE
supercell to `StructureData` type.
* Fixes a small oversight in the tests where `spglib_settings` was
  mistakenly named `spglib_options`.
  • Loading branch information
PNOGillespie committed Apr 29, 2024
1 parent 7b6c210 commit 019001c
Show file tree
Hide file tree
Showing 2 changed files with 248 additions and 161 deletions.
Loading

0 comments on commit 019001c

Please sign in to comment.