Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor AIIDA_CONFIG_FOLDER -> AiiDAConfigDir #9

Merged
merged 4 commits into from
Dec 10, 2024

Conversation

khsrali
Copy link
Contributor

@khsrali khsrali commented Dec 9, 2024

After aiidateam/aiida-core#6610 by @unkcpz AIIDA_CONFIG_FOLDER has changed to AiiDAConfigDir,
This PR refactors that accordingly.

@superstar54 superstar54 self-requested a review December 10, 2024 15:01
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.05%. Comparing base (56a8b7f) to head (ca7a05b).

Additional details and impacted files
@@            Coverage Diff             @@
##             main       #9      +/-   ##
==========================================
+ Coverage   90.01%   90.05%   +0.03%     
==========================================
  Files          13       13              
  Lines         531      533       +2     
==========================================
+ Hits          478      480       +2     
  Misses         53       53              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@superstar54 superstar54 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks!

@superstar54 superstar54 merged commit 88d7117 into aiidateam:main Dec 10, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants