Place the --output-mode in front of job scritp #28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes aiidateam#27 `--output-mode` option was wrongly put in the end of the submit command which cause the problem that stdout of submit command is not json parsable. The test was not able to catch it because the command was defined in the test but not directly get from the scheduler. Test is update to using the commond generated from scheduler and therefore being tested directly.
for more information, see https://pre-commit.ci
|
This is a critical bug and leftover from previous change, so I merge it directly. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #27
--output-modeoption was wrongly put in the end of the submit command which cause the problem that stdout of submit command is not json parsable. The test was not able to catch it because the command was defined in the test but not directly get from the scheduler. Test is update to using the commond generated from scheduler and therefore being tested directly.