Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change alloc add worker name aiida -> ahq #26

Merged
merged 2 commits into from
Jul 22, 2024
Merged

Change alloc add worker name aiida -> ahq #26

merged 2 commits into from
Jul 22, 2024

Conversation

unkcpz
Copy link
Member

@unkcpz unkcpz commented Jul 19, 2024 •
edited
Loading

Original name is aiida-xx for jobs, which is same as regular aiida job. I change it to ahq (i.e. aiida-hq) to distinguish it.
I don't think we need to let user able to change it.

@unkcpz
Change alloc add worker name aiida -> ahq
fa1203f 
Original name is `aiida-xx` for jobs, which is same as regular aiida job. I change it to `ahq` (i.e. aiida-hq) to distinguish it.
@unkcpz unkcpz requested a review from t-reents July 19, 2024 15:42
t-reents
t-reents approved these changes Jul 22, 2024
View reviewed changes
Copy link
Contributor

@t-reents t-reents left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was first thinking to explicitly use aiidahq <id> but this might be too long to be fully displayed anyway, therefore, I'm also fine with ahq <id>

@unkcpz unkcpz merged commit 9073fc0 into main Jul 22, 2024
2 of 4 checks passed
@unkcpz unkcpz deleted the unkcpz-patch-1 branch July 22, 2024 09:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@t-reents t-reents t-reents approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@unkcpz @t-reents