mypy: ignore[assignment] is no longer needed in src/aiida/orm/utils/serialize.py::51
#6566
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
khsrali
changed the title
mypy: Ignore assignment is no longer needed
khsrali
changed the title
mypy: Ignore assignment is no longer neededmypy: ignore[assignment] is no longer needed in src/aiida/orm/utils/serialize.py::51
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #6566 +/- ##
==========================================
+ Coverage 77.51% 77.83% +0.33%
==========================================
Files 560 566 +6
Lines 41444 41983 +539
==========================================
+ Hits 32120 32675 +555
+ Misses 9324 9308 -16 ☔ View full report in Codecov by Sentry. |
agoscinski
approved these changes
Sep 20, 2024
|
Really, adding more test for that line is out of scope of this PR. |
GeigerJ2
pushed a commit
to GeigerJ2/aiida-core
that referenced
this pull request
Sep 25, 2024
…ects (aiidateam#6566) Apparently, somehow `mypy` is updated and it is complaining about an `ignore[assignment]` comment that previously was imposed by `mypy` itself. (in src/aiida/orm/utils/serialize.py::L51) This commit removed `ignore[assignment]`, and `ci-style / pre-commit (pull_request)` is passing now.
agoscinski
pushed a commit
to agoscinski/aiida-core
that referenced
this pull request
Nov 5, 2024
…ects (aiidateam#6566) Apparently, somehow `mypy` is updated and it is complaining about an `ignore[assignment]` comment that previously was imposed by `mypy` itself. (in src/aiida/orm/utils/serialize.py::L51) This commit removed `ignore[assignment]`, and `ci-style / pre-commit (pull_request)` is passing now. Cherry-pick: 655da5a
agoscinski
pushed a commit
to agoscinski/aiida-core
that referenced
this pull request
Nov 5, 2024
…ects (aiidateam#6566) Apparently, somehow `mypy` is updated and it is complaining about an `ignore[assignment]` comment that previously was imposed by `mypy` itself. (in src/aiida/orm/utils/serialize.py::L51) This commit removed `ignore[assignment]`, and `ci-style / pre-commit (pull_request)` is passing now. Cherry-pick: 655da5a
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
mypyis somehow magically updated 🤔