Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix publishing to DockerHub #6423

Merged
merged 1 commit into from
May 27, 2024
Merged

Conversation

danielhollas
Copy link
Collaborator

@danielhollas danielhollas commented May 27, 2024

Publish to docker.io unfortunately failed on main. Hopefully this is the only mistake 🤞

https://github.com/aiidateam/aiida-core/actions/runs/9254901990/job/25458533243

Copy link

codecov bot commented May 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.66%. Comparing base (ef60b66) to head (e8433e9).
Report is 112 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6423      +/-   ##
==========================================
+ Coverage   77.51%   77.66%   +0.16%     
==========================================
  Files         560      562       +2     
  Lines       41444    41652     +208     
==========================================
+ Hits        32120    32344     +224     
+ Misses       9324     9308      -16     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sphuber sphuber merged commit 9c9ff79 into aiidateam:main May 27, 2024
19 checks passed
@danielhollas danielhollas deleted the fix/dockerhub branch May 27, 2024 19:33
@danielhollas
Copy link
Collaborator Author

dockerhub publish succeeded!

https://github.com/aiidateam/aiida-core/actions/runs/9259469149/job/25471957396
https://hub.docker.com/r/aiidateam/aiida-core-with-services

mikibonacci pushed a commit to mikibonacci/aiida-core that referenced this pull request Sep 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants