GHA: Fix test-install workflow #6409
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danielhollas
commented
May 22, 2024
| @@ -239,7 +239,7 @@ jobs: | |||
| # updating the requirements (in case they are inconsistent with the pyproject.toml file). | |||
| - uses: actions/upload-artifact@v4 | |||
| with: | |||
| name: requirements.txt | |||
| name: requirements-py-${{ matrix.python-version }}.txt | |||
There was a problem hiding this comment.
upload-artifact@v4 no longer allows uploading multiple artifacts under the same name.
|
Thanks @danielhollas . What was the actual main failure here? Was it the unsupported use of |
|
Well, there were three fatal failures, but the one that ruled them all was the uses line, which made the whole workflow invalid which hid the other issues. |
mikibonacci
pushed a commit
to mikibonacci/aiida-core
that referenced
this pull request
Sep 3, 2024
* The `uses` key requires full relative path when using a local path
to include, i.e., the leading `./` is required in the following:
used: `./.github/actions/install-aiida-core
* The action `upload-artifact@v4` no longer supports uploading multiple
files with the same name, so they now include the Python version.
* The Sphinx extension test is made more robust by making it insensitive
to the version of docutils used.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a workflow file is faulty, GitHub UI doesn't even bother showing the workflow at all on PR page. Thanks, I hate it.
https://github.com/aiidateam/aiida-core/actions/runs/9182083348