Make mypy pass with Python 3.12 #6408
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mypy was failing due to missing distutils module. + other small changes: - Bump mypy version to 1.10.0 - Bump pre-commit version
sphuber
approved these changes
May 22, 2024
mikibonacci
pushed a commit
to mikibonacci/aiida-core
that referenced
this pull request
Sep 3, 2024
Also make `mypy` pass for Python 3.12 and newer, which is failing due to missing `distutils` module in those versions.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mypy was failing for me locally on Fedora 39 with Python 3.12 due to missing
distutilsmodule.I modified the deprecated
get_strict_versionfunction so that we raise explicitly for python 3.12 and above. This also fixed the mypy error.Other drive-by changes: