Capture ImportTestRun as dry-run success
#6403
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GeigerJ2
force-pushed
the
dry-archive-import
branch
from
2bc6f5e to
70949c7
Compare
sphuber
requested changes
May 17, 2024
There was a problem hiding this comment.
Thanks @GeigerJ2 Changes look good. Just kind of surprised that this wasn't tested yet. Could you please add a quick test? Should be very straightforward to add in tests/cmdline/commands/test_archive_import.py. Just need to make sure the command finishes correctly as opposed to excepting like it does now 😄
sphuber
requested changes
May 23, 2024
GeigerJ2
force-pushed
the
dry-archive-import
branch
from
70949c7 to
7f377fc
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6403 +/- ##
==========================================
+ Coverage 77.51% 77.67% +0.16%
==========================================
Files 560 562 +2
Lines 41444 41660 +216
==========================================
+ Hits 32120 32354 +234
+ Misses 9324 9306 -18 ☔ View full report in Codecov by Sentry. |
GeigerJ2
force-pushed
the
dry-archive-import
branch
from
7f377fc to
b0b0606
Compare
GeigerJ2
force-pushed
the
dry-archive-import
branch
from
f2cc633 to
2ca485c
Compare
sphuber
reviewed
May 27, 2024
sphuber
approved these changes
May 27, 2024
mikibonacci
pushed a commit
to mikibonacci/aiida-core
that referenced
this pull request
Sep 3, 2024
aiidateam#6403) The import module raises `ImportTestRun` after a dry-run of a importing archive has finished successfully. This was not caught separately by the `verdi archive import` command resulting in a critical error being returned even in the case of a successful dry-run. The exception is now caught and a success message is logged instead.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #6401
In the
_import_archive_and_migratefunction, theImportTestRunexception is specifically captured, success communicated to the user, and the function returned to not print the finalecho_successswhich is issued after actual archive import into the profile.