Use fastjsonschema to validate user configuration #6110
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks @danielhollas I want to put a hold on this one, because I was working on replacing |
We use jsonschema to validate user configuration upon each verdi invocation. The problem is that importing `jsonschema` package is very slow. In this PR we use the fastjsonschema instead. This package uses code generation for generating fast python code based on a given schema. To fully take advantage of this and to avoid the compilation step, the code is pre-compiled and checked-in. The disadvantage is that when the schema changes, the code needs to be re-generated as well.
danielhollas
force-pushed
the
fastjsonschema
branch
from
2e94930 to
ee4dd7c
Compare
|
Closed in favor of #6117 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We use jsonschema to validate user configuration upon each verdi invocation. The problem is that importing
jsonschemapackage is very slow.In this PR we use the fastjsonschema instead. This package uses code generation for generating fast python code based on a given schema.
To fully take advantage of this and to avoid the compilation step, the code is pre-compiled and checked-in. The disadvantage is that when the schema changes, the code needs to be re-generated as well.