👌 Improve calcfunction/workfunction typing #6077
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Are you aware of work in progress on backporting this to Python 3.9 in a stand-alone package, or does it mean we will have to wait with this PR until Python 3.9 support is dropped? Which will be April 2024 at the earliest. |
https://typing-extensions.readthedocs.io/en/latest/#ParamSpec |
sphuber
force-pushed
the
type-calcfunction
branch
2 times, most recently
from
3549ef6 to
dc661e9
Compare
|
@chrisjsewell Thanks for the PR. I have rebased it and addressed the outstanding problems for tests to pass. Not sure if you are still watching this space. Let me know if you want to have a look before I merge. |
Add fallback of import of `ParamSpec` for Python 3.9 Also rename `R` to `R_co` since it is covariant and that is the standard naming convention
sphuber
force-pushed
the
type-calcfunction
branch
from
dc661e9 to
b32d07e
Compare
|
Yeh no worries dude, merge away |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Utilising PEP 612, this addition adds beautiful static completions for functions decorated with
@calcfunctionor@workfunctionUsing the function normally still works as expected:
But now also the additional features of a process function work:
Unfortunately, PEP 612 was only introduced in Python 3.10, and so I haven't yet added a "fallback" for Python 3.9