-
Notifications
You must be signed in to change notification settings - Fork 192
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Docs: improve the backup section for v2.0 #5431
Conversation
f26ad00
to
eace281
Compare
This should be merged after the release of v2.0.0b1 |
93e26d4
to
d35b3e1
Compare
Thanks but why do you say this? All the documentation on the release of v2.0.0b1 should relate to that version, and I would also like to link to this in the change log. |
I added this when I realized that this is not the documentation that users should read when wanting to migrate to v2.0. As I later then realized and said in the Slack channel, we should simply add a link in the email that points to
We could add the note for legacy backends, but it is not identical to |
This feels confusing though. |
With AiiDA v2.0 the repository is now provided by the `disk-objectstore` which is optimized for being backed up with `rsync`. This means the old custom implementation of backing it up is no longer necessary nor supported. It can now simply be backed up using `rsync`. The instructions are updated and improved by tying the backup procedure to the storage backend used for the profile. This will allow to have other instructions for other storage backends in the future, as they will most likely not be the same.
d35b3e1
to
1388bd3
Compare
Not necessarily. I guess we should in this case actually stress that if they use the old custom backup script for their backups, they should create a backup before installing
Yes, but they won't have run the migration yet, and so the suggested method for the So conclusion: I think the only solution then is to make it clear in the email that people with large databases that have been using the custom backup script (if they have never used it, then there is no point, they might as well rsync it) should backup before installing v2.0. Not sure if we should then also incorporate this is in the documentation. In the backup section itself won't make much sense, because it might come too late and only read it after having updated the installation. |
I feel then that this should also be added to #5426, as the "canonical" place for how to go from v1.6 -> v2.0, or add something on the wiki and link to that? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Still a question for me, of where to put the "canonical" instructions for backing up, before migrating a 1.6 database (#5431 (comment)).
But I don't think that blocks this 👍
Fixes #4853
Fixes #2603
With AiiDA v2.0 the repository is now provided by the
disk-objectstore
which is optimized for being backed up with
rsync
. This means the oldcustom implementation of backing it up is no longer necessary nor
supported. It can now simply be backed up using
rsync
.The instructions are updated and improved by tying the backup procedure
to the storage backend used for the profile. This will allow to have
other instructions for other storage backends in the future, as they
will most likely not be the same.