Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR I provide the first WorkChain for phonon related properties calculations. The main workflow (CommonForceSetsWorkChain) uses as basis class the WorkChain of
aiida-phonopy
(thesetup.json
still needs to be updated). The post processing (for phonon properties) is then performed using the CalcJob, again, in aiida-phonopy.From this WorkChain, we can in the future devise common workflows for computing specific properties, e.g. phonon band structure, dos and pdos, thermal properties, ... .
Tests are provided.