Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Common Force Sets workflow #256

Closed
wants to merge 3 commits into from
Closed

Conversation

bastonero
Copy link

In this PR I provide the first WorkChain for phonon related properties calculations. The main workflow (CommonForceSetsWorkChain) uses as basis class the WorkChain of aiida-phonopy (the setup.json still needs to be updated). The post processing (for phonon properties) is then performed using the CalcJob, again, in aiida-phonopy.

From this WorkChain, we can in the future devise common workflows for computing specific properties, e.g. phonon band structure, dos and pdos, thermal properties, ... .

Tests are provided.

@sphuber
Copy link
Collaborator

sphuber commented Jan 26, 2022

Think you may have accidentally changed the permissions on all the files. Please revert that. Let me know if you don't know how and I can help out

@bastonero
Copy link
Author

Think you may have accidentally changed the permissions on all the files. Please revert that. Let me know if you don't know how and I can help out

Sorry Sebastian. Yes, I did not remember I had that branch in PR. Not very sure which is the best option to revert this. Would you mind to give me some hint?

@sphuber
Copy link
Collaborator

sphuber commented Jan 26, 2022

Try the following from your repo:

git checkout bastonero/phonons-wc
git fetch --all
git reset --soft master
chmod 644 setup.json  aiida_common_workflows/workflows/phonons/common_force_sets.py tests/workflows/phonons/test_workchain_force_sets.py
git add setup.json  aiida_common_workflows/workflows/phonons/common_force_sets.py tests/workflows/phonons/test_workchain_force_sets.py
git stash --keep-index

Now when you do git status you should just those three files marked as green ready to be committed. When the changes look ok, you commit and then git push -f bastonero phonons-wc

@bastonero
Copy link
Author

Thanks @sphuber, now it should be ok. I also committed some missing __init__.py.

@bastonero
Copy link
Author

bastonero commented May 24, 2023

I'll close this PR as I opened a new one with the new aiida-phonopy implementation.

EDIT: the new PR is #306

@bastonero bastonero closed this May 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants