Adding warning message for demo server #975
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is for small deployment (max cpus localhost < 3), and when precise protocol is chosen. This should be indeed triggered for small deployment like the Demo Server.
for more information, see https://pre-commit.ci
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #975 +/- ##
==========================================
+ Coverage 68.40% 68.43% +0.02%
==========================================
Files 111 111
Lines 6293 6292 -1
==========================================
+ Hits 4305 4306 +1
+ Misses 1988 1986 -2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
edan-bainglass
approved these changes
Dec 19, 2024
Comment on lines
+147
to
+155
| if ( | ||
| on_localhost and protocol == "precise" and localhost_cpus < 4 | ||
| ): # This means that we are in a small deployment. | ||
| alert_message += ( | ||
| f"Warning: The selected protocol is {protocol}, which is computationally demanding to run on localhost. " | ||
| f"Consider the following: <ul>" | ||
| + suggestions["change_configuration"] | ||
| + "</ul>" | ||
| ) |
There was a problem hiding this comment.
Hey @mikibonacci. I didn't notice it in the review, but what is localhost_cpus? It doesn't exist. What should be the logic here? Also, one of the tests failed?
edan-bainglass
added a commit
to edan-bainglass/aiidalab-qe
that referenced
this pull request
Dec 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #973
I will wait to merge this, as soon as #971 will be merged, so I can put the new variable name for the max cpus available in localhost (no more
localhost_cpus).