Fixing the estimation of available cpus for a machine (localhost) #971
+11
−16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(now under the `machine_cpus` variable, no more `localhost_cpus`) This is done by using the `get_default_mpiprocs_per_machine` method of the computer node.
for more information, see https://pre-commit.ci
I take the information from the computer setup: ```python default_mpiprocs = computer.get_default_mpiprocs_per_machine() ```
…ab-qe into fix/cpu_count
for more information, see https://pre-commit.ci
mikibonacci
changed the title
mikibonacci
commented
Dec 15, 2024
| self.num_cpus.value = 1 | ||
| self.num_cpus.description = "CPUs" | ||
| else: | ||
| default_mpiprocs = computer.get_default_mpiprocs_per_machine() | ||
| self.num_nodes.disabled = False | ||
| self.num_cpus.max = default_mpiprocs | ||
| self.num_cpus.value = default_mpiprocs | ||
| self.num_cpus.value = ( |
There was a problem hiding this comment.
this can fix the number of max cpus we can choose for a code, avoid the erroneous os.cpu_count
mikibonacci
commented
Dec 15, 2024
| localhost_cpus = os.cpu_count() | ||
| machine_cpus = orm.load_node( | ||
| pw_code_model.selected | ||
| ).computer.get_default_mpiprocs_per_machine() |
There was a problem hiding this comment.
I called machine_cpus as is not more only for localhost_cpus
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #937
This fixes #888
Issue #937 is fixed here,
while #888 is fixed here