Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump aiida-quantumespresso to 4.4.0 and unpinning pydantic #591

Merged
merged 1 commit into from
Jan 16, 2024

Conversation

unkcpz
Copy link
Member

@unkcpz unkcpz commented Jan 11, 2024

The pydantic is pinned in #416, after the release of aiida-quantumespresso it is not needed, this PR bump the aiida-quantumespresso and unpin the pydantic.

The pydantic is pinned in #416, after the release of `aiida-quantumespresso` it is not needed, this PR bump the aiida-quantumespresso and unpin the pydantic.
Copy link

codecov bot commented Jan 11, 2024

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (f63da7d) 80.73% compared to head (1343b58) 80.86%.
Report is 14 commits behind head on main.

Files Patch % Lines
src/aiidalab_qe/common/widgets.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #591      +/-   ##
==========================================
+ Coverage   80.73%   80.86%   +0.13%     
==========================================
  Files          49       49              
  Lines        3415     3429      +14     
==========================================
+ Hits         2757     2773      +16     
+ Misses        658      656       -2     
Flag Coverage Δ
python-3.10 80.86% <97.36%> (+0.13%) ⬆️
python-3.8 80.91% <97.36%> (+0.13%) ⬆️
python-3.9 80.91% <97.36%> (+0.13%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@unkcpz
Copy link
Member Author

unkcpz commented Jan 12, 2024

@AndresOrtegaGuerrero there is a new feature aiidateam/aiida-quantumespresso@d9b18a7, is it something we can use in qeapp?
Also will be helpful to go through the list of CHANGELOG to see if any other features and fix matters.

@AndresOrtegaGuerrero
Copy link
Member

@unkcpz Thank you . I will have a look , It could also be important if we ask about the status of some issues that are linked with some of the development of the app like, aiidateam/aiida-quantumespresso#998, aiidateam/aiida-quantumespresso#968 ,

Copy link
Member

@AndresOrtegaGuerrero AndresOrtegaGuerrero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! , maybe @unkcpz if you can remind peoplo from aiida-quantumespresso plugin about the pending issues

@unkcpz
Copy link
Member Author

unkcpz commented Jan 15, 2024

maybe @unkcpz if you can remind people from aiida-quantumespresso plugin about the pending issues

@mbercx, reminder for the guardian of aiida-quantumespresso 😸 aiidateam/aiida-quantumespresso#998 aiidateam/aiida-quantumespresso#968

I assign https://github.com/aiidateam/aiida-quantumespresso/pull/998/files to my self for the review.

@unkcpz unkcpz merged commit 5f40802 into main Jan 16, 2024
17 checks passed
@unkcpz unkcpz deleted the deps/xx/pydantic-and-qe-plugin branch January 16, 2024 15:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants