Update guides #1035
Merged
Update guides #1035
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
edan-bainglass
force-pushed
the
guide-text
branch
from
812b077 to
a23ad8f
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1035 +/- ##
==========================================
- Coverage 68.98% 68.93% -0.05%
==========================================
Files 113 113
Lines 6764 6770 +6
==========================================
+ Hits 4666 4667 +1
- Misses 2098 2103 +5
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
edan-bainglass
force-pushed
the
guide-text
branch
2 times, most recently
from
690e708 to
2423f64
Compare
edan-bainglass
force-pushed
the
guide-text
branch
2 times, most recently
from
8307f57 to
d796afc
Compare
|
Looks good to me , I just had suggestion , but everything looks ready. Feel free to discard suggestions |
|
Thanks @AndresOrtegaGuerrero. Note that this PR is on hold until we get the main guide text settled on with Giovanni and Carlo. We're meeting today to discuss this. |
edan-bainglass
force-pushed
the
guide-text
branch
4 times, most recently
from
80eedd7 to
ed2c3cc
Compare
|
@giovannipizzi @cpignedoli for reference
|
edan-bainglass
force-pushed
the
guide-text
branch
from
478632c to
0d0f7ad
Compare
edan-bainglass
force-pushed
the
guide-text
branch
from
c332f46 to
993f71a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR discards placeholder guide drafts and updates the content of the primary guide draft.
Closes #979