Main svc #3
Merged
Main svc #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Сформировано разбиение на пакеты и реализован слой контроллеров.
YazykovMikhail
approved these changes
Sep 14, 2024
| @Slf4j | ||
| @RestController | ||
| @RequiredArgsConstructor | ||
| public class AdminCategoriesController { |
|
|
||
| @ResponseStatus(HttpStatus.OK) | ||
| @PatchMapping("/admin/categories/{catId}") | ||
| public CategoryDto patchCategory(@PathVariable final Long catId, |
There was a problem hiding this comment.
Не стоит использовать одинаковые dto для создания. иобновления, ведь при создании поле id не должно приходить.
CategoryCreateRequest
CategoryUpdateRequest
если контракты рахные, стоит делать разыне дто, назови вот так
There was a problem hiding this comment.
Касается всех эндпоинтов
п.с Если контракт одинаковый можно использовать одну общую дто, н опри запросах такое не часто бывает
| @PositiveOrZero @PathVariable final Long eventId, | ||
| @Valid @RequestBody final UpdateEventUserRequest eventUpdateDto) { | ||
| log.info("PATCH /users/{}/events/{}", userId, eventId); | ||
| eventUpdateDto.setId(eventId); |
There was a problem hiding this comment.
Не нужно в дто делать пустых полей, что бы потом еще делать сет.
Делай потом уже в модель или куда нужно. А то получается в запросе(контракте) приходят пустые поля, а потом ты их сетаешь, но это дто для запроса, а не для внутренней логике
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
На проверку