Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PDDL Parser: more explicit error when facing empty expressions #60

Closed
wants to merge 1 commit into from
Closed

PDDL Parser: more explicit error when facing empty expressions #60

wants to merge 1 commit into from

Conversation

victorpaleologue
Copy link
Contributor

Supersedes #43

@victorpaleologue victorpaleologue mentioned this pull request Jul 20, 2021
Closed
@victorpaleologue
Copy link
Contributor Author

As discussed in http://issues.fast-downward.org/issue1030, we do the check only for goals, where the absence of a goal is clearly not supported (and perhaps should not). For other conditions, the spec is not clear so nothing was changed.

@FlorianPommerening FlorianPommerening force-pushed the main branch 6 times, most recently from 27d6a14 to c2a93e6 Compare February 2, 2023 00:20
@maltehelmert
Copy link
Contributor

Superseded by #155, so I'm closing this. But thank you for bringing this to our attention! This was what ultimately triggered the more extensive rewrite of the PDDL parser.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@victorpaleologue @maltehelmert