fix dangling pointer to state buffer in state registry #190
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
I'm fine with the pull request as is but would prefer some minor changes. Also, since this is such a central part of the code, I'd say it needs an experiment, maybe with blind search, to see if the performance is affected. Although, we don't have much choice since we have to fix the bug.
Independent of the issue, we could use this as a starting point to discuss the refactoring that was planned anyway, where we move successor generation out of the registry. Maybe a topic for a meeting?
FlorianPommerening
approved these changes
Oct 13, 2023
src/search/state_registry.cc
Outdated
| /* | ||
| TODO: ideally, we would not modify state_data_pool here and in | ||
| insert_id_or_pop_state, but only at one place, to avoid errors like | ||
| buffer becoming a dangling pointer. |
There was a problem hiding this comment.
I'd add a reference to the issue here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.