Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix CPLEX compilation on Windows for repos not named 'downward'. #188

Merged
merged 3 commits into from
Oct 6, 2023

Conversation

jendrikseipp
Copy link
Contributor

No description provided.

Copy link
Member

@FlorianPommerening FlorianPommerening left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like there are two conflicting solutions: Getting rid of the hard-coded paths D:\a\downward\ and working around them.

.github/workflows/windows.yml Outdated Show resolved Hide resolved
.github/workflows/windows.yml Outdated Show resolved Hide resolved
@jendrikseipp
Copy link
Contributor Author

Looks like there are two conflicting solutions: Getting rid of the hard-coded paths D:\a\downward\ and working around them.

Yes. I opted for the less intrusive one. Do you prefer the other one, i.e., using D:\a\cplex_temp and D:\a\cplex?

@FlorianPommerening
Copy link
Member

I'm fine with using the environment variable but what I meant was that there are still places with the hard-coded paths. It would make sense to use the variable path everywhere instead of using hard-coded paths in some places and variable paths in others.

@jendrikseipp
Copy link
Contributor Author

I now install CPLEX directly under D:\a\cplex, removing the need for the mkdir hack. Now I'm using env vars everywhere it's possible, I think. Good to merge now?

@FlorianPommerening
Copy link
Member

That makes more sense now. The installation is still weird but I think all of that weirdness was there before (for example, the copy from cplex_temp to cplex because for some reason we cannot directly install to cplex). I'm fine with merging this.

@jendrikseipp jendrikseipp changed the title Allow compiling with CPLEX in repos not named 'downward'. Fix CPLEX compilation on Windows for repos not named 'downward'. Oct 6, 2023
@jendrikseipp jendrikseipp merged commit 64070d0 into aibasel:main Oct 6, 2023
12 checks passed
@jendrikseipp jendrikseipp deleted the cplex-ci branch October 6, 2023 09:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants