Support string options in parser #170
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DillonZChen
added a commit
to DillonZChen/goose
that referenced
this pull request
Aug 20, 2023
FlorianPommerening
force-pushed
the
issue1106
branch
from
c3c79d5 to
e3de553
Compare
src/search/utils/strings.cc
Outdated
| return result; | ||
| } | ||
|
|
||
| string unescape(const string &s) { |
There was a problem hiding this comment.
Is it worth mentioning in a code comment that this will not do syntax-checking and therefore accepts "illegal" strings? Illegal strings are those where the final character is an unescaped "" or where an escaping "" is not followed by one of the characters from the specific set that can follow an escaping "".
SimonDold
approved these changes
Nov 21, 2023
SimonDold
approved these changes
Nov 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not complete yet: we want to handle the cases in
lexical_analyzer.cc(construct_token_type_expressionsandsplit_tokens) better. So far, this just supports strings in double quotes that have no quotes inside.