Allow offline diags to work for 2D only outputs #2137
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This issue describes a problem where the offline diags require
pressure_thickness_of_atmospheric_layervariable to be loaded even if the model is only predicting 2D outputs and doesn't use this information for diagnostics.This PR adds an optional flag
--outputs-2d-onlythat can be set to allow the diagnostics to proceed without loading this variable. It also addsoffline-diags-flagsas an optional argo parameter foroffline-diagsandtrain-diags-progtemplates so this flag andn-jobscan be set for argo jobs.Resolves #<2136> [JIRA-TAG]
Coverage reports (updated automatically):