Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Fortran so FMS is built with -DGFS_PHYS #63

Merged
merged 3 commits into from
Apr 22, 2020

Conversation

oliverwm1
Copy link
Contributor

This has the effect of changing the physical constants used by fv3gfs and thus required a change to the md5sum files in fv3gfs-fortran.

Copy link
Collaborator

@mcgibbon mcgibbon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are a couple different changes bundled here, make sure you've tested regression in fv3gfs-fortran on all the changes apart from the changing of physical constants, and applied the physical constants update separately. I'm just trusting you've done that already in that repo (so it's fine to bundle them here).

May want to also add the corresponding entry for the new 0.3.x version.

@oliverwm1
Copy link
Contributor Author

There are a couple different changes bundled here, make sure you've tested regression in fv3gfs-fortran on all the changes apart from the changing of physical constants, and applied the physical constants update separately. I'm just trusting you've done that already in that repo (so it's fine to bundle them here).

Yes good point. Indeed in the fv3gfs-fortran PR, I made the physical constants change apart from anything else, and confirmed that that was the change that required a modification of the regression test data. But since that commit came after the coarse-graining code, it's easiest to bundle them together for this PR to fv3gfs-python.

@oliverwm1
Copy link
Contributor Author

May want to also add the corresponding entry for the new 0.3.x version.

I'll do this in #62

@oliverwm1 oliverwm1 merged commit 72ad37c into master Apr 22, 2020
@oliverwm1 oliverwm1 deleted the feature/latest-fortran branch April 22, 2020 20:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants