Refactor build logic to lib/Makefile #110
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
the responsibility of building/linking code was split between the setup.py and lib/Makefile. This commit combines all the fortran static objects into a single libcoupler.a archive, which simplifies the setup.py. This archive is built by lib/Makefile
It was too hard to combine .a files into a single archive. The linker does this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit refactors some pure fortran routines from
templates/_wrapper.pyxtolib/tracers.f90. These routines will be used in a future PR to add getters/setters for the physics tracers data.Since this required modifying the build system, I took the opportunity to refactor that a bit. The responsibility of building/linking code was split between the setup.py and lib/Makefile, and there was a fair amount of complexity associated with handling the linking arguments for the fortran model outputs.
Now, the
lib/Makefilebuilds a single static librarylib/libcoupler.athat combines all of static fortran objects. Thesetup.pyfor the wrapper then adds the link arguments-Llib -lcoupler. I also restructured the logic ofsetup.pyinto a few functions.