Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Raise error for misconfigured field_tables #132

Merged
merged 3 commits into from
Jan 21, 2021
Merged

Raise error for misconfigured field_tables #132

merged 3 commits into from
Jan 21, 2021

Conversation

spencerkclark
Copy link
Member

@spencerkclark spencerkclark commented Jan 21, 2021 •
edited
Loading

The termination of the model now looks like the following if an "sgs_tke" tracer is not defined in the field_table of a simulation set to use the TKE-EDMF turbulence scheme. Previously the model would uninformatively crash with a segmentation fault.

FATAL from PE     2: GFS_typedefs::control_initialize An sgs_tke tracer must be defined in the field_table if gfs_physics_nml.satmedmf is true.

===================================================================================
=   BAD TERMINATION OF ONE OF YOUR APPLICATION PROCESSES
=   PID 9 RUNNING AT 25332af98bdf
=   EXIT CODE: 1
=   CLEANING UP REMAINING PROCESSES
=   YOU CAN IGNORE THE BELOW CLEANUP MESSAGES
===================================================================================

This was referenced Jan 21, 2021
Merged
Open
@nbren12
Copy link
Contributor

nbren12 commented Jan 21, 2021

Related to #130

nbren12
nbren12 approved these changes Jan 21, 2021
View reviewed changes
Copy link
Contributor

@nbren12 nbren12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Can you shorten the title? Maybe "Raise error for misconfigured field_tables" would work?

oelbert
oelbert approved these changes Jan 21, 2021
View reviewed changes
Copy link
Contributor

@oelbert oelbert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Always in favor of more descriptive errors

@spencerkclark spencerkclark changed the title Raise informative error if an sgs_tke tracer is not defined in the field table when using the TKE-EDMF scheme Raise error for misconfigured field_tables Jan 21, 2021
@spencerkclark spencerkclark merged commit 6ff352a into master Jan 21, 2021
@spencerkclark spencerkclark deleted the tke-edmf-error branch January 21, 2021 22:25
ofuhrer pushed a commit that referenced this pull request Mar 5, 2021
@spencerkclark @ofuhrer
Raise error for misconfigured field_tables (#132)
acc1251
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oelbert oelbert oelbert approved these changes

@nbren12 nbren12 nbren12 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@spencerkclark @nbren12 @oelbert