Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

issue #29: Tagarno API documentation and API integration #54

Draft
wants to merge 15 commits into
base: main
Choose a base branch
from

Conversation

MaxenceGui
Copy link

@MaxenceGui MaxenceGui commented Jan 31, 2024

This PR is the continuing work of

Refer to the PR for code and previous reviews.

  • Add documentation on Tagarno API objectives
  • Add get_picture_details function
  • Add manual test

@MaxenceGui MaxenceGui self-assigned this Jan 31, 2024
@MaxenceGui MaxenceGui added this to the M1 (2023Q4) milestone Jan 31, 2024
@MaxenceGui MaxenceGui linked an issue Jan 31, 2024 that may be closed by this pull request
"recommendations": [
"stkb.rewrap"
]
}
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

EOF newline missing!

Please add relevant Github workflows to ensure these issues are caught automatically

https://github.com/ai-cfia/github-workflows/blob/main/.github/workflows/workflow-repo-standards-validation.yml

@rngadam
Copy link

rngadam commented Feb 4, 2024

Something that occurred to me following our discussions: the properties set in the image from the microscope device when capturing with the microscope and transferring the image are probaly not going to follow when we are capturing from the in-browser image canvas (where the microscope is working as a webcam source).

@MaxenceGui
Copy link
Author

MaxenceGui commented Feb 5, 2024

@rngadam

Yes, the webcam component we use in the front end is not capturing any metadata since we only took a screenshot of the canvas. I find this other component (Expo Camera). The component has a function call takePictureAsync that can get exif data if the image object recorded it.

@rngadam
Copy link

rngadam commented Feb 6, 2024

Yes, the webcam component we use in the front end is not capturing any metadata since we only took a screenshot of the canvas. I find this other component (Expo Camera). The component has a function call takePictureAsync that can get exif data if the image object recorded it.

I'm somewhat skeptical this will work with our microscope and return the manufacturer exif but worth testing!

@MaxenceGui MaxenceGui removed their assignment Mar 27, 2024
@MaxenceGui MaxenceGui changed the title issue #29: Tagarno API documentation and issue #29: Tagarno API documentation and API integration Apr 24, 2024
@MaxenceGui MaxenceGui force-pushed the 29-retrieve-metadata-from-microscope branch from bd820ad to b9ddbd0 Compare April 25, 2024 15:16
@MaxenceGui
Copy link
Author

Pull Request Status Update

Summary

This PR was open to work on the Tagarno API integration into Nachet. As of today (April 25), the AI Lab doesn't have either a microscope or a license for the API. Meaning that the PR is blocked for now.

If the conditions to work on the PR are good again, here is what the dev should know:

  • Documentation was started and is located to /docs/tagarno-api-objective.md
  • Code is located at /microcscope/microscope_info.py
  • Test is located at /tests/test_microscope_info.py

However, there still work to be done, that why the PR is still in draft.

  • Unittest needs to be written
  • Code for Tagarno's API integration need revisit and work
  • Documentation will need to be update as you implement your solution

@MaxenceGui MaxenceGui force-pushed the 29-retrieve-metadata-from-microscope branch from 190f27e to b60950a Compare April 25, 2024 15:39
@MaxenceGui MaxenceGui added the Blocked Issue and PR that are blocked in their advancement label Apr 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Blocked Issue and PR that are blocked in their advancement
Projects
Status: Blocked
Development

Successfully merging this pull request may close these issues.

Develop API to interface with Tagarno microscope API
3 participants