httpev: add http_bind function #6
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Khady
reviewed
Oct 2, 2020
httpev.ml
Outdated
| match addr, Systemd.Daemon.listen_fds_lwt () with | ||
| | None, [] -> | ||
| log#error "bind not provided and no systemd socket available"; | ||
| exit 1 |
There was a problem hiding this comment.
can't use exit here, one might want to recover from the error or try again
cyberhuman
reviewed
Oct 2, 2020
httpev.ml
Outdated
| @@ -1119,6 +1119,21 @@ let setup_lwt config answer = | |||
| let server_lwt config answer = | |||
| Lwt_main.run @@ setup_lwt config answer | |||
|
|
|||
| let http_bind addr http_config = | |||
There was a problem hiding this comment.
I think this function should be named setup_<something> because it's what it does. E.g. setup_bind_lwt.
level-a
force-pushed
the
httpev/http_bind
branch
from
be187d3
to
0fd77bb
Compare
Khady
approved these changes
Oct 5, 2020
|
can this be merged? |
setup http_server with http_config binded to systemd socket (by default) or to provided addr (host:port)
level-a
force-pushed
the
httpev/http_bind
branch
from
0fd77bb
to
4703287
Compare
Khady
approved these changes
Nov 5, 2020
ygrek
suggested changes
Nov 19, 2020
| @@ -1119,6 +1123,24 @@ let setup_lwt config answer = | |||
| let server_lwt config answer = | |||
| Lwt_main.run @@ setup_lwt config answer | |||
|
|
|||
| let setup_bind_lwt addr config answer = | |||
There was a problem hiding this comment.
there is config.connection which this api totally ignores which is not cool. Instead we should break api and make config.connection a variant itself and make all setup_* functions honor that variant and provide convenience functions to set that variant
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
setup http_server with http_config binded to systemd socket (by default) or to provided addr (host:port)