Skip to content

Commit

Permalink
chore: Switching equality library to fast-deep-equal
Browse files Browse the repository at this point in the history
  • Loading branch information
aholstenson committed Oct 12, 2018
1 parent bc720a2 commit 3726957
Show file tree
Hide file tree
Showing 5 changed files with 20 additions and 14 deletions.
20 changes: 11 additions & 9 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@
"dependencies": {
"date-fns": "^2.0.0-alpha.20",
"fast-clone": "^1.5.3",
"lodash.isequal": "^4.5.0",
"fast-deep-equal": "^2.0.1",
"talisman": "^0.21.0"
},
"devDependencies": {
Expand Down
4 changes: 2 additions & 2 deletions resolver/builder.js
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
'use strict';

const isEqual = require('lodash.isequal');
const { isDeepEqual } = require('../utils/equality');
const ResolverParser = require('./parser');

const ResolvedIntent = require('./resolved-intent');
Expand Down Expand Up @@ -122,7 +122,7 @@ function uniqueIntentFilter(added, intent, score) {
function partialIntentFilter(added, match) {
let matches = added[match.intent] || (added[match.intent] = []);
for(let i=0; i<matches.length; i++) {
if(isEqual(matches[i], match.values)) {
if(isDeepEqual(matches[i], match.values)) {
matches.push(match.values);
return false;
}
Expand Down
5 changes: 3 additions & 2 deletions resolver/value-parser.js
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
'use strict';
const isEqual = require('lodash.isequal');

const { isDeepEqual } = require('../utils/equality');

const Node = require('../parser/node');
const SubNode = require('../parser/sub');
Expand All @@ -24,7 +25,7 @@ class ValueParser extends Node {

equals(o) {
return o instanceof ValueParser && this.node.equals(o.node)
&& isEqual(this.options, o.options);
&& isDeepEqual(this.options, o.options);
}

match(encounter) {
Expand Down
3 changes: 3 additions & 0 deletions utils/equality.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
'use strict';

module.exports.isDeepEqual = require('fast-deep-equal');

0 comments on commit 3726957

Please sign in to comment.