Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ESD-1228: [patch] Fix autolink jira duplication #15

Closed
wants to merge 3 commits into from

Conversation

jodiethecodie
Copy link
Contributor

@jodiethecodie jodiethecodie commented Apr 18, 2024

Jira issue: ESD-1228

What does this PR do?

Attempt #2 to fix autolink

@github-actions github-actions bot changed the title [patch] Fix autolink jira duplication ESD-1228: [patch] Fix autolink jira duplication Apr 18, 2024
@@ -13,7 +13,8 @@ jobs:
autolink:
name: Add Jira Link to PR Title/Description
runs-on: ubuntu-latest
if: ${{ github.event_name == 'pull_request' && !startsWith(github.event.pull_request.title, '[A-Za-z\d-_.\\/]+') }}
if: ${{ github.event_name == 'pull_request' && !startsWith(github.event.pull_request.title, '([A-Za-z]{2,3})-(\d{1,5})') }}

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will it never add Jira link to PR desc?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only when the jira tag doesn't exist on the title, i.e it's never prepended the jira link

@jodiethecodie
Copy link
Contributor Author

It's apparently already merged so .. closing?

@jodiethecodie jodiethecodie deleted the esd-1228-autolink-fix branch April 21, 2024 23:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants