HADOOP-18889. Third party storage followup. (apache#6186)

Followup to HADOOP-18889 third party store support; Fix some minor review comments which came in after the merge.
ahmarsuhail · Dec 5, 2023 · e14b08b · e14b08b
1 parent 8a1eb91
commit e14b08b
Show file tree

Hide file tree

Showing 2 changed files with 1 addition and 11 deletions.
diff --git a/hadoop-tools/hadoop-aws/src/main/java/org/apache/hadoop/fs/s3a/S3AFileSystem.java b/hadoop-tools/hadoop-aws/src/main/java/org/apache/hadoop/fs/s3a/S3AFileSystem.java
@@ -1358,7 +1358,7 @@ public String getBucketLocation() throws IOException {
     public String getBucketLocation(String bucketName) throws IOException {
       final String region = trackDurationAndSpan(
           STORE_EXISTS_PROBE, bucketName, null, () ->
-              once("getBucketLocation()", bucketName, () ->
+              invoker.retry("getBucketLocation()", bucketName, true, () ->
                   // If accessPoint then region is known from Arn
                   accessPoint != null
                       ? accessPoint.getRegion()

diff --git a/hadoop-tools/hadoop-aws/src/main/java/org/apache/hadoop/fs/s3a/auth/SignerFactory.java b/hadoop-tools/hadoop-aws/src/main/java/org/apache/hadoop/fs/s3a/auth/SignerFactory.java
@@ -81,16 +81,6 @@ public static void registerSigner(
     SIGNERS.put(signerType, signerClass);
   }
 
-  /**
-   * Check if the signer has already been registered.
-   * @param signerType signer to get
-   * @throws IllegalArgumentException if the signer type is unknown.
-   */
-  public static void verifySignerRegistered(String signerType) {
-    checkArgument(isSignerRegistered(signerType),
-        "unknown signer type: %s", signerType);
-  }
-
   /**
    * Check if the signer has already been registered.
    * @param signerType signer to get