Enable accessibility module (#471)

* Enable accessibility module * Add some waitFor
ahmadsoe · Jul 26, 2024 · 75c4728 · 75c4728
1 parent 27d92a8
commit 75c4728
Show file tree

Hide file tree

Showing 2 changed files with 21 additions and 0 deletions.
diff --git a/ember-highcharts/src/components/high-charts.ts b/ember-highcharts/src/components/high-charts.ts
@@ -207,6 +207,9 @@ export default class HighCharts extends Component<HighChartsSignature> {
       Highcharts = await import('highcharts');
     }
 
+    const Accessibility = await import('highcharts/modules/accessibility');
+    Accessibility.default(Highcharts);
+
     // 3d support
     if (this.args.chartOptions?.chart?.options3d) {
       const Boost = await import('highcharts/modules/boost');

diff --git a/test-app/tests/integration/components/high-charts-test.js b/test-app/tests/integration/components/high-charts-test.js
@@ -19,6 +19,8 @@ module('Integration | Component | High Charts', function (hooks) {
       <HighCharts />
     `);
 
+    await waitFor('.highcharts-credits');
+
     // custom highcharts-configs/application.js is auto-loaded from tests/dummy/app
     assert
       .dom('.highcharts-credits')
@@ -41,6 +43,8 @@ module('Integration | Component | High Charts', function (hooks) {
       />
     `);
 
+    await waitFor('.highcharts-legend');
+
     assert
       .dom('.highcharts-legend .highcharts-legend-item text')
       .exists({ count: 1 }, 'expected one series');
@@ -52,13 +56,16 @@ module('Integration | Component | High Charts', function (hooks) {
   test('should add a series', async function (assert) {
     this.cityData = cityData;
     this.lineChartOptions = lineChartOptions;
+
     await render(hbs`
       <HighCharts
         @content={{this.cityData}}
         @chartOptions={{this.lineChartOptions}}
       />
     `);
 
+    await waitFor('.highcharts-legend');
+
     assert
       .dom('.highcharts-legend .highcharts-legend-item')
       .exists({ count: 3 }, 'base series count');
@@ -83,13 +90,16 @@ module('Integration | Component | High Charts', function (hooks) {
   test('should remove a series', async function (assert) {
     this.cityData = cityData;
     this.lineChartOptions = lineChartOptions;
+
     await render(hbs`
       <HighCharts
         @content={{this.cityData}}
         @chartOptions={{this.lineChartOptions}}
       />
     `);
 
+    await waitFor('.highcharts-legend');
+
     assert
       .dom('.highcharts-legend .highcharts-legend-item')
       .exists({ count: 3 }, 'base series count');
@@ -175,27 +185,35 @@ module('Integration | Component | High Charts', function (hooks) {
     await render(hbs`
       <HighCharts />
     `);
+    await waitFor('.highcharts-container');
+
     assert
       .dom('.highcharts-container')
       .exists({ count: 1 }, 'we rendered a chart without a mode specified');
 
     await render(hbs`
       <HighCharts @mode="" />
     `);
+    await waitFor('.highcharts-container');
+
     assert
       .dom('.highcharts-container')
       .exists({ count: 1 }, 'we rendered a chart with empty string mode');
 
     await render(hbs`
       <HighCharts @mode={{false}}/>
     `);
+    await waitFor('.highcharts-container');
+
     assert
       .dom('.highcharts-container')
       .exists({ count: 1 }, 'we rendered a chart with false boolean mode');
 
     await render(hbs`
       <HighCharts @mode={{null}}/>
     `);
+    await waitFor('.highcharts-container');
+
     assert
       .dom('.highcharts-container')
       .exists({ count: 1 }, 'we rendered a chart with null mode');