Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: correctly consume escape for consume string token #2

Merged
merged 2 commits into from
Nov 11, 2024

Conversation

inottn
Copy link
Contributor

@inottn inottn commented Nov 9, 2024

fix web-infra-dev/rspack#8384

I'm not sure if this fix is correct, so feel free to modify it or just close the PR if needed.

Copy link

codspeed-hq bot commented Nov 11, 2024

CodSpeed Performance Report

Merging #2 will not alter performance

Comparing inottn:fix/consume (14f99f8) with main (88abe44)

Summary

✅ 1 untouched benchmarks

@ahabhgk ahabhgk changed the title fix: resolve incorrect handling of backslash escapes in consume_string fix: correctly consume escape for consume string token Nov 11, 2024
@ahabhgk ahabhgk merged commit 619244b into ahabhgk:main Nov 11, 2024
3 checks passed
@inottn inottn deleted the fix/consume branch November 11, 2024 06:57
@Narretz
Copy link

Narretz commented Nov 12, 2024

Thanks @inottn and @ahabhgk for fixing this so quickly. Do you know when the new version will land in rspack?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: asset processing broken in production with unicode private area codes
3 participants