Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use a NEM file that is already in memory #49

Merged
merged 5 commits into from
Mar 22, 2024

Conversation

markmckenzie
Copy link
Contributor

No description provided.

@pep8speaks
Copy link

pep8speaks commented Jan 13, 2024

Hello @markmckenzie! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

Line 34:61: E252 missing whitespace around parameter equals
Line 34:62: E252 missing whitespace around parameter equals
Line 122:1: W293 blank line contains whitespace

Line 22:80: E501 line too long (87 > 79 characters)

Comment last updated at 2024-03-22 00:22:49 UTC

(excluding line too long warnings)
@aguinane
Copy link
Owner

Looks like this is getting some decoing errors?
FAILED tests/test_open_examples.py::test_nem12_examples - UnicodeDecodeError: 'utf-8' codec can't decode byte 0xcd in position 10: invalid continuation byte

@markmckenzie
Copy link
Contributor Author

Looks like this is getting some decoing errors? FAILED tests/test_open_examples.py::test_nem12_examples - UnicodeDecodeError: 'utf-8' codec can't decode byte 0xcd in position 10: invalid continuation byte

Yep I can see what happened, will sort it out

markmckenzie and others added 2 commits January 15, 2024 23:25
Allow passing in a file-like object as well as a path.
@aguinane aguinane merged commit f357d07 into aguinane:master Mar 22, 2024
0 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants