Rethink Atlas layout and components #457
Conversation
steveoh
commented
Jul 25, 2024
steveoh
commented
- Use design system components
- Remove bootstrap css
|
Visit the preview URL for this PR (updated for commit fbd5bdd): |
|
well this is a new issue. |
| @@ -1,18 +1,19 @@ | |||
| { | |||
| "name": "@ugrc/atlas", | |||
| "version": "5.4.14", | |||
| "version": "5.4.13", | |||
There was a problem hiding this comment.
| "version": "5.4.13", | |
| "version": "5.4.14", |
Did you mean to do this?
There was a problem hiding this comment.
This was maybe a rebase from main since the next version is .15
There was a problem hiding this comment.
Can these fonts be loaded via google fonts to simplify our project tree?
There was a problem hiding this comment.
i like the idea of supporting both ways
| import { BootstrapDartboard as FindAddress } from '@ugrc/dart-board'; | ||
| import Sherlock, { WebApiProvider } from '@ugrc/sherlock'; | ||
| import { | ||
| Drawer, |
There was a problem hiding this comment.
Should this component be moved into Atlas since it's dependent on the app structure?
| // mapComponent.current = new EsriMap(); | ||
|
|
||
| mapComponent.current = new WebMap({ | ||
| portalItem: { | ||
| id: '80c26c2104694bbab7408a4db4ed3382', | ||
| }, | ||
| }); |
There was a problem hiding this comment.
This is pointing to the UIC web map. We either need to create one specific to Atlas or build a map with the API directly. I'm not sure what advantage there is to creating a web map for atlas since it wouldn't have any layers.
There was a problem hiding this comment.
I believe this is a remnant of a race condition in layer selector.
|
Sorry, I didn't think the draft pr was trying to de deployed and this wasn't ready for a review. I wanted to share the layout with you and others who can't run it locally. But thank you for taking a look at it!
|
this requires linking @ugrc/utah-design-system
|
closing in favor of dev so deploy previews work. |
