implement domainExtractor for image and title, with a single implementation wikipedia #30
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First thanks for sharing this code. It's exactly what i needed, and i didn't find anything i liked in NodeJS.
This is more a request to get feedback then actual pull request.
The problem i encountered is that wikipedia does not work with the image and title extraction that's implemented now.
The Image is not in the header, but is the first image in the '.infobox'.
Title- When splitting the Title, the longest part is usually not the important part, like in 'Thomas Edison - Wikipedia, the free encyclopedia'
Trying to tackle this problem i saw 2 options:
Obviously i decided to use the second option.
There is still work to be done and issues to address, but I would like to get your input on the proposed solution.
Thank you for your time!