Fixed side effect from invocation of cleaner in unfluff.lazy #21
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was sure that I checked that for #16 but it seems that I missed that.
cleaner
mutates originaldoc
object sodoc
needs to be re-calculated. So right now aftercleaner
is applied we will suffer from side effect. Consider next example:Using this code over
test_tags_kexp.html
fixture we will have different results fortags()
sincecleaner
is called insidetext()
.So when
cleaner
is called we need to reload document. Besides, I added some refactoring.