Merge pull request #9 from ageekdev/feat/name-normalize

Feat: add normalization for mm names

src/MMName.php

@@ -4,12 +4,13 @@
 
 use AgeekDev\MMName\Traits\EnglishSarHelpers;
 use AgeekDev\MMName\Traits\MyanmarSarHelpers;
+use AgeekDev\MMName\Utilities\Normalizer;
 use Illuminate\Support\Facades\Config;
 use Illuminate\Support\Traits\Macroable;
 
-class MMName
+class MMName extends Normalizer
 {
-    use MyanmarSarHelpers, EnglishSarHelpers, Macroable;
+    use EnglishSarHelpers, Macroable, MyanmarSarHelpers;
 
     protected array $dataSource;
 
@@ -24,11 +25,11 @@ public function __construct()
     public function convertToEn(string $nameString): string
     {
         if (! $this->isMmName($nameString)) {
-            return $nameString;
+            return $this->normalizeMmText($nameString);
         }
 
         $enName = '';
-        $nameSegments = $this->myanmarSarSegment($nameString);
+        $nameSegments = $this->myanmarSarSegment($this->normalizeMmText($nameString));
 
         foreach (explode(' ', $nameSegments) as $name) {
             $enName .= ($this->dataSource['mm'][$name] ?? '').' ';

src/Utilities/Normalizer.php

@@ -0,0 +1,22 @@
+<?php
+
+namespace AgeekDev\MMName\Utilities;
+
+/**
+ * Normalize the Myanmar Texts
+ */
+class Normalizer
+{
+    private array $normalizations = [
+        '/\x{1037}\x{103A}/u' => '့်',
+    ];
+
+    public function normalizeMmText(string $text): string
+    {
+        foreach ($this->normalizations as $pattern => $replace) {
+            $text = preg_replace($pattern, $replace, $text);
+        }
+
+        return $text;
+    }
+}

tests/NameConverterTest.php

@@ -62,9 +62,6 @@
 });
 
 it('can convert myanmar name to myan-glish', function () {
-    $result = mm_name_to_en('မောင်မောင်');
-    expect($result)->toEqual('mg mg');
-
     $result = MMName::convertToEn('မောင်မောင်');
     expect($result)->toEqual('mg mg');
 
@@ -136,4 +133,10 @@
 
     $result = MMName::convertToEn('စန္ဒာ');
     expect($result)->toEqual('sandar');
+
+    $result = MMName::convertToEn('မောင်သန့်သူ');
+    expect($result)->toEqual('mg thant thu');
+
+    $result = MMName::convertToEn('မောင်မောင်ကျော်');
+    expect($result)->toEqual('mg mg kyaw');
 });