Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add default document loader and parser for RAG #624

Merged
merged 5 commits into from
Jan 23, 2025
Merged

Conversation

AgentGenie
Copy link
Collaborator

Why are these changes needed?

Add document loader and parser (Docling) for RAG.

Related issue number

#438

Checks

@marklysze
Copy link
Collaborator

marklysze commented Jan 22, 2025

Thanks @AgentGenie!

A couple of things:

  • Can you change function names from docline to docling
  • Tests are failing with missing packages, @davorrunje is there anything in particular needed here when using new packages

On the note of selenium, it may also be a worthwhile option to look at using the Crawl4AI package to scrape the page when loading a URL. They say "Creates smart, concise Markdown optimized for RAG and fine-tuning applications.".

@marklysze
Copy link
Collaborator

Thanks for updating the parser name, can you also add an extra and packages to the pyproject.toml for all the additional packages required.

@davorrunje
Copy link
Collaborator

Thanks for updating the parser name, can you also add an extra and packages to the pyproject.toml for all the additional packages required.

I fixed the packaging and related stuff, will push my changes soon.

Copy link
Collaborator

@marklysze marklysze left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@marklysze
Copy link
Collaborator

Gemini test failure unrelated.

@marklysze marklysze merged commit e2e6607 into main Jan 23, 2025
236 of 237 checks passed
@marklysze marklysze deleted the document_parser branch January 23, 2025 21:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants