Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding AnthropicVertexAI API support in the Anthropic LLM lib under oai #309

Merged

Conversation

shriyanshagnihotri
Copy link
Collaborator

@shriyanshagnihotri shriyanshagnihotri commented Dec 28, 2024

Why are these changes needed?

The changes include adding support AnthropicVertex inside oai/anthropic.py and oai/client.py, so that Anthropic models running in GCP can be used in Ag2 for building Agents.

Related issue number

Closes #308

Checks

@shriyanshagnihotri shriyanshagnihotri force-pushed the main-feature-308-AnthropicVertexSupport branch from 3b9f073 to 07fa4e3 Compare December 29, 2024 06:27
@marklysze
Copy link
Collaborator

Hey @shriyanshagnihotri, thanks for putting this PR together.

I have tested it without GCP and with GCP and it works well!

It's currently not passing the pre-commit tests because it's missing a blank line as the last line in the both the anthropic.py and test_anthropic.py files, can you please add them in?

Also, are you on discord, would you be able to message me your email address so we can send through a CLA (Contributor License Agreement) for your contribution? My Discord is msze_.

@marklysze marklysze added enhancement New feature or request alt-models labels Dec 29, 2024
@marklysze
Copy link
Collaborator

Can I also ask if you could add instructions to the documentation page for Anthropic:
/website/docs/topics/non-openai-models/cloud-anthropic.ipynb

It will be useful for others looking to do the same.

@shriyanshagnihotri shriyanshagnihotri force-pushed the main-feature-308-AnthropicVertexSupport branch from bef7962 to 1633fbf Compare December 30, 2024 14:27
@shriyanshagnihotri
Copy link
Collaborator Author

@marklysze please check, I have updated the documentation as well. Also regarding the extra enter, I have added, but it seems the pre-commit is removing it. please check

@marklysze
Copy link
Collaborator

@marklysze please check, I have updated the documentation as well. Also regarding the extra enter, I have added, but it seems the pre-commit is removing it. please check

Thanks @shriyanshagnihotri, if you're able to give me access to the repository I can edit it.

@shriyanshagnihotri
Copy link
Collaborator Author

@marklysze : Done I have added you as a writer to https://github.com/test-zeus-ai/ag2

@marklysze
Copy link
Collaborator

Thanks @shriyanshagnihotri, I've just tweaked the notebook text a bit to format the bullet points. All passed the pre-commit so I think we're good to go :)

@marklysze marklysze added this pull request to the merge queue Dec 31, 2024
Merged via the queue into ag2ai:main with commit 3c49da8 Dec 31, 2024
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
alt-models enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature Request]: AnthropicVertexAI API support in the Anthropic LLM support
2 participants