-
Notifications
You must be signed in to change notification settings - Fork 146
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding AnthropicVertexAI API support in the Anthropic LLM lib under oai #309
Adding AnthropicVertexAI API support in the Anthropic LLM lib under oai #309
Conversation
3b9f073
to
07fa4e3
Compare
Hey @shriyanshagnihotri, thanks for putting this PR together. I have tested it without GCP and with GCP and it works well! It's currently not passing the pre-commit tests because it's missing a blank line as the last line in the both the Also, are you on discord, would you be able to message me your email address so we can send through a CLA (Contributor License Agreement) for your contribution? My Discord is |
Can I also ask if you could add instructions to the documentation page for Anthropic: It will be useful for others looking to do the same. |
bef7962
to
1633fbf
Compare
@marklysze please check, I have updated the documentation as well. Also regarding the extra enter, I have added, but it seems the pre-commit is removing it. please check |
Thanks @shriyanshagnihotri, if you're able to give me access to the repository I can edit it. |
@marklysze : Done I have added you as a writer to https://github.com/test-zeus-ai/ag2 |
Thanks @shriyanshagnihotri, I've just tweaked the notebook text a bit to format the bullet points. All passed the pre-commit so I think we're good to go :) |
Why are these changes needed?
The changes include adding support AnthropicVertex inside oai/anthropic.py and oai/client.py, so that Anthropic models running in GCP can be used in Ag2 for building Agents.
Related issue number
Closes #308
Checks