Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: adds missing import for gemini #304

Merged
merged 2 commits into from
Dec 27, 2024
Merged

Conversation

abossenbroek
Copy link
Collaborator

Why are these changes needed?

When using Gemini as LLM client, an error was reported caused by a missing package installation. Due to this error it was not possible to use Gemini as a LLM client. The bug is resolved by adding jsonschema as dependency.

Related issue number

No separate ticket was opened for this issue.

Checks

Local test

On a fresh venv, before the patch the behavior when installing with [gemini] was,
Screenshot 2024-12-27 at 10 33 37

after the fix, the behavior is,

Screenshot 2024-12-27 at 10 34 27

@marklysze
Copy link
Collaborator

@abossenbroek, thanks so much... I've tested the pip install gemini and it works without exception, thanks!

Once tests go through, we can merge!

@marklysze marklysze added this pull request to the merge queue Dec 27, 2024
Merged via the queue into main with commit 6cc0a81 Dec 27, 2024
208 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
alt-models bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants