Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the ReasoningAgent to CI #294

Merged
merged 7 commits into from
Jan 1, 2025
Merged

Add the ReasoningAgent to CI #294

merged 7 commits into from
Jan 1, 2025

Conversation

Hk669
Copy link
Collaborator

@Hk669 Hk669 commented Dec 26, 2024

Why are these changes needed?

Add ReasoningAgent to CI

Related issue number

N/A

Checks

@marklysze
Copy link
Collaborator

Thanks @Hk669, Is the graphviz package installing as part of the tests? The last two tests are failing for me (and although they are mocking graphviz, it will still need it installed).

@Hk669
Copy link
Collaborator Author

Hk669 commented Dec 27, 2024

let me try to fix the tests.

@Hk669
Copy link
Collaborator Author

Hk669 commented Jan 1, 2025

@marklysze can you take a look at the changes, i think these should fix this installation problem for the CI tests.

@Hk669 Hk669 enabled auto-merge January 1, 2025 11:56
@marklysze marklysze changed the title add the reasoningagent to CI Add the ReasoningAgent to CI Jan 1, 2025
Copy link
Collaborator

@marklysze marklysze left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Hk669!

@Hk669 Hk669 added this pull request to the merge queue Jan 1, 2025
@sonichi sonichi removed this pull request from the merge queue due to a manual request Jan 1, 2025
@sonichi
Copy link
Collaborator

sonichi commented Jan 1, 2025

@Hk669 I'm holding off merging this PR. This CI should be made as optional and only triggered when necessary.
cc @BabyCNM @qingyun-wu @davorrunje @marklysze
Update: this PR doesn't do benchmarking, so it's OK to merge now.

@sonichi sonichi added this pull request to the merge queue Jan 1, 2025
@marklysze marklysze removed this pull request from the merge queue due to a manual request Jan 1, 2025
@marklysze marklysze added this pull request to the merge queue Jan 1, 2025
Merged via the queue into main with commit 445132a Jan 1, 2025
227 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants