Magentic one skeleton #224
Conversation
This reverts commit eb5ac4c.
…ry, and the message history never gets reset. Make this the default behavior, but give the option to only pass the task to the agent and give the option to reset the agent's history after it accomplishes the task.
…inal implementation.
Merlinvt
force-pushed
the
magentic-one-skeleton
branch
from
209b6a7 to
b4770b8
Compare
|
Would merge this help to merge other PRs? |
|
|
||
| @property | ||
| def page_content(self) -> str: | ||
| return "test_page_content" |
There was a problem hiding this comment.
Please consider all code as production code.
return tmp value is not a good practice.
Can't you just do pass here?
| pass | ||
|
|
||
| def visit_page(self, path_or_uri: str) -> str: | ||
| return "test_visit_page" |
There was a problem hiding this comment.
same here and other places
|
|
||
|
|
||
| def test_requests_markdown_browser_address(browser): | ||
| assert browser.address == "test_address" |
There was a problem hiding this comment.
You don't need to test a method if it is not implemented.
| # SPDX-License-Identifier: Apache-2.0 | ||
| # | ||
| # Portions derived from https://github.com/microsoft/autogen are under the MIT License. | ||
| # SPDX-License-Identifier: MIT |
| # SPDX-License-Identifier: Apache-2.0 | ||
| # | ||
| # Portions derived from https://github.com/microsoft/autogen are under the MIT License. | ||
| # SPDX-License-Identifier: MIT |
| # SPDX-License-Identifier: Apache-2.0 | ||
| # | ||
| # Portions derived from https://github.com/microsoft/autogen are under the MIT License. | ||
| # SPDX-License-Identifier: MIT |
There was a problem hiding this comment.
No class or actual code?
|
The skeleton code is usually used to show the structure of the project and show how the interfaces/classes work together without implement the code. |
Merlinvt
force-pushed
the
magentic-one-skeleton
branch
from
376f986 to
03ca569
Compare
Magentic One Skeleton