Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Magentic One Websurfer #192

Open
wants to merge 4 commits into
base: magentic-one
Choose a base branch
from
Open

Conversation

Merlinvt
Copy link
Collaborator

Websurfer Agent. The tool calling in this state is still a chimera between the old implementation and the AG2 way. I do have a local state that makes better use of the functionality provided by AG2. But I first wanted to get this version merged. By merging the changes later and getting some feedback on them, I am hoping to make sure that the functionality stays the same.

@Merlinvt Merlinvt assigned yanenli2 and unassigned yanenli2 Dec 11, 2024
@Merlinvt Merlinvt changed the title Web surfer Magentic One Web-surfer Dec 11, 2024
@Merlinvt Merlinvt changed the title Magentic One Web-surfer Magentic One Websurfer Dec 11, 2024
TOOL_VISIT_URL = {
"type": "function",
"function": {
"name": "visit_url",
Copy link
Collaborator

@AgentGenie AgentGenie Dec 18, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please give a magentic one specific name. General name may lead to overwriting other tools.
Also applies to following tool names.

@AgentGenie
Copy link
Collaborator

To merge the PR, we need to close the following gaps.

  1. Please add docs to all public APIs and interface/class.
  2. Add tests/notebooks to show Websurfer could run properly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants