Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix base_url not work in groq #162

Merged
merged 1 commit into from
Dec 11, 2024
Merged

fix base_url not work in groq #162

merged 1 commit into from
Dec 11, 2024

Conversation

simplaj
Copy link
Contributor

@simplaj simplaj commented Dec 6, 2024

Why are these changes needed?

The base_url functionality in Groq was not working correctly in AutoGen version 0.4.1. This PR addresses the issue by fixing the logic for handling the base_url parameter, ensuring it functions as expected.

Related issue number

Checks

@Hk669 Hk669 requested a review from marklysze December 6, 2024 17:48
@marklysze
Copy link
Collaborator

@simplaj, thanks so much for adding support for base_url. I've tested your changes and they look good!

Can I have your Discord ID and email so that we can acknowledge your contribution, and also have you sign CLA properly! I'm msze_ on Discord if you wanted to message me, or you can catch me on the AG2 Discord server.

@simplaj
Copy link
Contributor Author

simplaj commented Dec 7, 2024

Thank you for testing and confirming the changes! I appreciate your acknowledgment and would be happy to provide my Discord ID and email for proper CLA signing. My Discord ID is tianzhihua, and my email is [email protected]. I'll also message you on Discord shortly to stay in touch.

Thanks again for your support!

@sonichi sonichi requested a review from sternakt December 7, 2024 19:07
Copy link
Collaborator

@marklysze marklysze left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

@marklysze
Copy link
Collaborator

Passed tests, except OpenAI which can't run as not in repo. Won't affect OpenAI as Groq specific. Merging.

@marklysze marklysze added this pull request to the merge queue Dec 11, 2024
Merged via the queue into ag2ai:main with commit 5f15f54 Dec 11, 2024
202 of 210 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants